Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup_expired_logs timestamp #503

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Fix cleanup_expired_logs timestamp #503

merged 1 commit into from
Nov 24, 2021

Conversation

mosyp
Copy link
Contributor

@mosyp mosyp commented Nov 24, 2021

  1. fix cleanup_expired_logs which used timestamp() which are seconds but not millis
  2. fix delete_expired_delta_log_in_checkpoint by adding missing check on version 2 and using modified on the actual file (which is used in comparison rather then log action json)

@mosyp
Copy link
Contributor Author

mosyp commented Nov 24, 2021

cc @viirya

@mosyp mosyp merged commit 52d2098 into delta-io:main Nov 24, 2021
viirya
viirya reviewed Nov 24, 2021
View reviewed changes
Copy link
Contributor

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mosyp mosyp deleted the fix-millis branch November 24, 2021 18:11
@mosyp mosyp mentioned this pull request Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya left review comments

@xianwill xianwill xianwill approved these changes

@rtyler rtyler Awaiting requested review from rtyler

@houqp houqp Awaiting requested review from houqp

@fvaleye fvaleye Awaiting requested review from fvaleye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosyp @viirya @xianwill