chore: include license files in published crates #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankane
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
ankane
force-pushed
the
license-files
branch
2 times, most recently
from
992299f
to
3802cd8
Compare
ankane
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 128 128
Lines 40831 40831
Branches 40831 40831
=======================================
+ Hits 29591 29593 +2
- Misses 9355 9356 +1
+ Partials 1885 1882 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nicklan
pushed a commit
to delta-io/delta-kernel-rs
that referenced
this pull request
Nov 21, 2024
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-incubator/delta-kernel-rs/blob/main/CONTRIBUTING.md 2. Run `cargo t --all-features --all-targets` to get started testing, and run `cargo fmt`. 3. Ensure you have added or run the appropriate tests for your PR. 4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 5. Be sure to keep the PR description updated to reflect all changes. --> ## What changes are proposed in this pull request? <!-- Please clarify what changes you are proposing and why the changes are needed. The purpose of this section is to outline the changes, why they are needed, and how this PR fixes the issue. If the reason for the change is already explained clearly in an issue, then it does not need to be restated here. 1. If you propose a new API or feature, clarify the use case for a new API or feature. 2. If you fix a bug, you can clarify why it is a bug. --> Hi, this symlinks the license and notice files so they're included in the published crates (related: delta-io/delta-rs#3009). ```sh cd kernel ln -s ../LICENSE . ln -s ../NOTICE . cd ../derive-macros ln -s ../LICENSE . ln -s ../NOTICE . ``` <!-- Uncomment this section if there are any changes affecting public APIs: ### This PR affects the following public APIs If there are breaking changes, please ensure the `breaking-changes` label gets added by CI, and describe why the changes are needed. Note that _new_ public APIs are not considered breaking. --> ## How was this change tested? <!-- Please make sure to add test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested, ideally via a reproducible test documented in the PR description. --> N/A Co-authored-by: Zach Schuermann <[email protected]>
Signed-off-by: Andrew Kane <[email protected]>
ion-elgreco
force-pushed
the
license-files
branch
from
3802cd8
to
02ec73b
Compare
ion-elgreco
approved these changes
Nov 22, 2024
|
Thanks @ion-elgreco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, thanks for this project! This symlinks the license file so it's included in published crates.
Related Issue(s)
None
Documentation
N/A