fix: num rows statistics #2990
Merged
fix: num rows statistics #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewiszlw
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
lewiszlw
force-pushed
the
fix-num-rows-stat
branch
2 times, most recently
from
7e11cbf
to
4883f0c
Compare
rtyler
approved these changes
Nov 21, 2024
Signed-off-by: Linwei Zhang<[email protected]> Signed-off-by: 张林伟 <[email protected]>
ion-elgreco
force-pushed
the
fix-num-rows-stat
branch
from
34fddd7
to
6faf599
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
- Coverage 72.47% 72.41% -0.07%
==========================================
Files 128 128
Lines 40857 40859 +2
Branches 40857 40859 +2
==========================================
- Hits 29613 29588 -25
+ Misses 9360 9356 -4
- Partials 1884 1915 +31 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to get correct
num_rowsstatistics for optimizingselect count(*) from xxxcase.Related Issue(s)
Documentation