Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally disable enable_io non-unix based systems #2884

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

hntd187
Copy link
Collaborator

@hntd187 hntd187 commented Sep 13, 2024

Description

Disabled the ability to enable_io on non-unix systems

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Sep 13, 2024
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@hntd187 hntd187 changed the title bug: conditionally disable enable_io non-unix based systems fix: Conditionally disable enable_io non-unix based systems Sep 13, 2024
@hntd187 hntd187 changed the title fix: Conditionally disable enable_io non-unix based systems fix: conditionally disable enable_io non-unix based systems Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.64%. Comparing base (47376a6) to head (f7a8e46).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/storage/mod.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
+ Coverage   72.63%   72.64%   +0.01%     
==========================================
  Files         131      131              
  Lines       40015    40016       +1     
  Branches    40015    40016       +1     
==========================================
+ Hits        29064    29071       +7     
- Misses       9088     9091       +3     
+ Partials     1863     1854       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@hntd187 hntd187 added this pull request to the merge queue Sep 13, 2024
Merged via the queue into delta-io:main with commit 73107a7 Sep 13, 2024
21 checks passed
@hntd187 hntd187 deleted the fix-tokio-windows branch September 13, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants