Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escaped columns in dataskippingstatscolumns #2855

Merged

Conversation

ion-elgreco
Copy link
Collaborator

Description

We parse the indents and then join them again with "." since the parquet SchemaDescriptor is using full paths.

Related Issue(s)

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Sep 7, 2024
@ion-elgreco ion-elgreco added this pull request to the merge queue Sep 7, 2024
Merged via the queue into delta-io:main with commit 3127c81 Sep 7, 2024
22 checks passed
@ion-elgreco ion-elgreco deleted the fix/stats_collection_escaped_columns branch September 7, 2024 19:03
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (f05b2bf) to head (79ae537).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/writer/stats.rs 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2855      +/-   ##
==========================================
- Coverage   72.53%   72.49%   -0.04%     
==========================================
  Files         132      132              
  Lines       40029    40046      +17     
  Branches    40029    40046      +17     
==========================================
- Hits        29036    29033       -3     
- Misses       9140     9158      +18     
- Partials     1853     1855       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats missing for dataSkippingStatsColumns when escaping column name
2 participants