-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-enable optional old casting behavior in merge #2853
fix: re-enable optional old casting behavior in merge #2853
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
==========================================
- Coverage 72.64% 72.62% -0.02%
==========================================
Files 131 131
Lines 40015 40015
Branches 40015 40015
==========================================
- Hits 29068 29062 -6
Misses 9087 9087
- Partials 1860 1866 +6 ☔ View full report in Codecov by Sentry. |
@ion-elgreco I'm sure you're getting busier as the autumn is starting, so i'll try to be quick:
|
We are, but some type coercion in Datafusion isn't working properly yet, particularly list <=> large list. So I only re add it temporarily. The test will be short lived I guess, and the transformation code is well tested so should be fine. I made an upstream issue for this type coercion problem Last question I don't get? :p |
eb6d42a
to
cbe2265
Compare
Description
The description of the main changes of your pull request
Related Issue(s)
#2851
@ericvandever, this doesn't fix the coercion but allows you to still use large_dtypes=False to downcast so that you can still run most of your queries