-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stats is optional in add action #2841
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2841 +/- ##
==========================================
- Coverage 72.50% 72.48% -0.02%
==========================================
Files 132 132
Lines 40049 40057 +8
Branches 40049 40057 +8
==========================================
- Hits 29038 29036 -2
Misses 9159 9159
- Partials 1852 1862 +10 ☔ View full report in Codecov by Sentry. |
2266a5a
to
3b5db70
Compare
@jkylling I am trying to add a test case to validate this scenario and cannot reproduce the issue since my Add actions with no stats are coming through. Lots of our tests have Add actions with no stats too 😕 |
This code path seems to only be triggered when reading checkpoints without a |
@jkylling can you add a test for this |
Head branch was pushed to by a user without write access
e8339cf
to
4d1a156
Compare
@rtyler @ion-elgreco I've added a test with a checkpoint without a stats column. Please have a look. |
Description
The stats field in add actions is optional, https://github.com/delta-io/delta/blob/master/PROTOCOL.md#add-file-and-remove-file
We currently silently skip reading add actions from snapshots without stats.
Related Issue(s)
Documentation