chore: remove some file_actions call sites
#2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
wjones127,
fvaleye,
ion-elgreco,
rtyler and
hntd187
as code owners
github-actions
bot
added
binding/python
ion-elgreco
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
file_actionsmethod on our various state representations is quite inefficient, since it does some often unnecessary work converting out internal arrow state to theAddaction representation. This PR removes some of the easy to remove call sites and does some drive by cleanup on the way.All this is in preparation for some bigger work refactoring our checkpoint writing and generally fully embracing the arrow state.
Related Issue(s)
Documentation