chore: refactor write_deltalake in writer.py
#2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpgmaas
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
ion-elgreco
reviewed
Jul 22, 2024
ion-elgreco
previously approved these changes
Jul 22, 2024
auto-merge was automatically disabled
July 24, 2024 05:27
Head branch was pushed to by a user without write access
|
@ion-elgreco sorry, could you trigger the pipeline once again? I accidentally used |
ion-elgreco
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Te body of the
write_deltalakefunction is quite long, and thus a bit difficult to read and understand. This PR proposes to reduce the complexity of thewrite_deltalakefunction a little bit, by extracting some logic to a separate function, and moving some function definitions to outside of the body.I guess this is a bit opinionated, so if you think this does not add value, feel free to close the PR.