feat(rust): fix size_in_bytes in last_checkpoint_ to i64 #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sherlockbeard thanks for the pull request! I had been following the issue but haven't had the time to consider it further. Do you know if Spark writes int64s in the JSON stats?64-bit or larger are of unclear validity in JSON to me, since JavaScript loves 32bit numbers if Spark is willing to write 64bit numbers to JSON, I sure am too 😄 |
sherlockbeard
changed the title
sherlockbeard
force-pushed
the
deletionVectorSizeinByte
branch
from
83e7e6e
to
51868a8
Compare
|
@rtyler revised my changes !.
Yes looks like size and num_of_add_files are also long in spark . |
rtyler
approved these changes
Jul 6, 2024
nicklan
pushed a commit
to delta-incubator/delta-kernel-rs
that referenced
this pull request
Jul 9, 2024
In spark delta these stats are long https://github.com/delta-io/delta/blob/97439835a4a667ac2ad86ec6054f0e85e8214760/spark/src/main/scala/org/apache/spark/sql/delta/LastCheckpointInfo.scala#L102-L112 see delta-io/delta-rs#2649 for more information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see #2646
Related Issue(s)
closes #2646
Documentation