Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement regression test for push down panic #2604

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Jun 15, 2024

See #2602

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jun 15, 2024
@abhiaagarwal
Copy link
Contributor

@rtyler I haven't tested this yet, but try:

fn supports_filters_pushdown(
&self,
_filter: &[&Expr],
) -> DataFusionResult<Vec<TableProviderFilterPushDown>> {
Ok(vec![TableProviderFilterPushDown::Inexact])
}

Ok(filter.into_iter().map(|_| TableProviderFilterPushDown::Inexact).collect())

or something of this nature.

@rtyler
Copy link
Member Author

rtyler commented Jun 17, 2024

@abhiaagarwal I gave that a try in a small slot of time I had yesterday with no success, I haven't been able to spend more time with the problem yet 😦

@abhiaagarwal
Copy link
Contributor

abhiaagarwal commented Jun 17, 2024

@rtyler there's also the same slip of logic below it, did you change both spots?

fn supports_filters_pushdown(
&self,
_filter: &[&Expr],
) -> DataFusionResult<Vec<TableProviderFilterPushDown>> {
Ok(vec![TableProviderFilterPushDown::Inexact])
}

I'm not even sure these need to be Inexact as well. Might be worth telling Datafusion it gives exact results and seeing what happens :)

@rtyler rtyler marked this pull request as ready for review June 19, 2024 18:04
@rtyler rtyler enabled auto-merge (rebase) June 19, 2024 18:04
@rtyler rtyler requested a review from ion-elgreco June 20, 2024 22:45
@rtyler rtyler merged commit a300218 into main Jun 21, 2024
20 checks passed
@rtyler rtyler deleted the df-regression-2602 branch June 21, 2024 06:03
mildbyte added a commit to splitgraph/seafowl that referenced this pull request Jun 26, 2024
mildbyte added a commit to splitgraph/seafowl that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants