-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement regression test for push down panic #2604
Conversation
@rtyler I haven't tested this yet, but try: delta-rs/crates/core/src/delta_datafusion/mod.rs Lines 699 to 704 in df6e6fd
Ok(filter.into_iter().map(|_| TableProviderFilterPushDown::Inexact).collect()) or something of this nature. |
@abhiaagarwal I gave that a try in a small slot of time I had yesterday with no success, I haven't been able to spend more time with the problem yet 😦 |
@rtyler there's also the same slip of logic below it, did you change both spots? delta-rs/crates/core/src/delta_datafusion/mod.rs Lines 778 to 783 in df6e6fd
I'm not even sure these need to be Inexact as well. Might be worth telling Datafusion it gives exact results and seeing what happens :) |
bbed8f3
to
7c7d156
Compare
See #2602