fix(rust, python): fixed differences in storage options between log and object stores #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd object stores causing divergent dynamodb behavior
mightyshazam
force-pushed
the
fix-aws-region-imds
branch
from
a03d328
to
2a3cdc8
Compare
rtyler
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object store changes the keys used for creating the s3 options, while the log store does not. The difference between the two, and their usage together was causing some weird fallback behavior in the AWS SDK that invoked the IMDS service despite explicitly disabling it in multiple places. This fix handles the potentially different casing along with passing the options unmolested. It should stop any future, unwanted, IMDS behavior
Description
The description of the main changes of your pull request
Related Issue(s)
Documentation