Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve daft integration docs #2496

Merged
merged 7 commits into from
May 20, 2024

Conversation

avriiil
Copy link
Contributor

@avriiil avriiil commented May 9, 2024

This PR improves the Daft integration docs to better highlight key Delta features.

@avriiil avriiil requested a review from MrPowers as a code owner May 9, 2024 14:47
Copy link

github-actions bot commented May 9, 2024

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@avriiil avriiil changed the title improve daft integration docs docs: improve daft integration docs May 9, 2024
Copy link
Collaborator

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrPowers MrPowers enabled auto-merge (squash) May 10, 2024 16:45
@avriiil
Copy link
Contributor Author

avriiil commented May 20, 2024

@MrPowers - ubuntu_latest build is failing, not sure how to resolve. traceback:

running 3 tests
test test_action_reconciliation ... ok
test test_concurrency_local ... FAILED
test test_integration_local ... ok

failures:

---- test_concurrency_local stdout ----
thread 'tokio-runtime-worker' panicked at /home/runner/work/delta-rs/delta-rs/crates/test/src/concurrent.rs:149:35:
called `Result::unwrap()` on an `Err` value: ObjectStore { source: Generic { store: "LocalFileSystem", source: Metadata { source: Error { depth: 1, inner: Io { path: Some("/tmp/.tmpV3LdnO/concurrent_workers/_delta_log/_commit_900c41d2-4500-46a3-909e-90a370819a27.json.tmp"), err: Os { code: 2, kind: NotFound, message: "No such file or directory" } } }, path: "_delta_log/_commit_900c41d2-4500-46a3-909e-90a370819a27.json.tmp" } } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'test_concurrency_local' panicked at /home/runner/work/delta-rs/delta-rs/crates/test/src/concurrent.rs:69:28:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(102), ...)

@ion-elgreco
Copy link
Collaborator

ion-elgreco commented May 20, 2024

@avriiil it's a flaky test that one, so no worries, I retriggered it

@MrPowers MrPowers merged commit 11ab3f6 into delta-io:main May 20, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants