fix(rust): implement abort commit for S3DynamoDBLogStore #2452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures when using
S3DynamoDBLogStore
, temp commit files are only deleted when the DynamoDB log entry is deleted.Add
abort_commit_entry(version, tmp_commit)
toLogStore
tmp_commit
fileS3DynamoDBLogStore
, it first deletes the DynamoDB entry. Then, it only deletestmp_commit
if the entry is deleted successfullyContext
This fixes a rare bug when using DynamoDB as the locking provider. Consider the following events:
S3DynamoDbLogStore.write_commit_entry
succeeds at creating a DynamoDB entry, but fails duringrepair_entry
tmp_commit
filerepair_entry
is called on this entry, it will lead toObjectStoreError::NotFound
since the temp commit file was deletedThis results in a complete DynamoDB log entry, even though the corresponding transaction log does not exist in
_delta_log
.Related Issue(s)