fix(python, rust): check timestamp_ntz in nested fields, add check_can_write in pyarrow writer #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye,
roeap and
rtyler
as code owners
ion-elgreco
force-pushed
the
fix/check_timestamp_ntz_recursively
branch
from
0a5aeb2
to
efe7ec9
Compare
github-actions
bot
added
binding/python
wjones127
previously approved these changes
Apr 23, 2024
ion-elgreco
changed the title
ion-elgreco
changed the title
wjones127
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nested fields weren't checked, which meant you could get a timestampNtz in your schema but not have the reader/writer features set. This check is now done recursively.