Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): writer missing invariants feature #2412

Closed
wants to merge 1 commit into from

Conversation

kallydev
Copy link

@kallydev kallydev commented Apr 13, 2024

Description

The default version of Writer is 2, but the global ProtocolChecker is missing the invariants feature, which causes ProtocolChecker::can_write_to to return an UnsupportedWriterFeatures error. The error prevents me from passing false to the nullable field of StructField::new without the use of the datafunction feature.

Error: Transaction failed: Unsupported writer features required: [Invariants]

Caused by:
    Unsupported writer features required: [Invariants]

Related Issue(s)

Documentation

pub fn default_writer_version(&self) -> i32 {
2
}

delta-rs/README.md

Lines 159 to 164 in d49d95b

### Protocol Support Level
| Writer Version | Requirement | Status |
| -------------- | --------------------------------------------- | :-------------------------------: |
| Version 2 | Append Only Tables | ![done] |
| Version 2 | Column Invariants | ![done] |

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Apr 13, 2024
@ion-elgreco
Copy link
Collaborator

@kallydev it needs to be behind a Datafusion feature flag since invariants uses Datafusion to check the record batches according to the predicates

@kallydev
Copy link
Author

@kallydev it needs to be behind a Datafusion feature flag since invariants uses Datafusion to check the record batches according to the predicates

OK, it seems like this is not an error. Thanks for your review! :)

@kallydev kallydev closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
2 participants