Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Daft integration #2402

Merged
merged 6 commits into from
Apr 13, 2024
Merged

Conversation

avriiil
Copy link
Contributor

@avriiil avriiil commented Apr 9, 2024

This adds an integration page for using Delta Lake with Daft.

@avriiil avriiil requested a review from MrPowers as a code owner April 9, 2024 09:53
@ion-elgreco
Copy link
Collaborator

Not so sure about promoting daft here, they collect telemetry by default...

@MrPowers
Copy link
Collaborator

MrPowers commented Apr 9, 2024

Seems like their telemetry gathering is responsible, but open to thoughts: https://www.getdaft.io/projects/docs/en/latest/faq/telemetry.html

@ion-elgreco
Copy link
Collaborator

I don't really agree, no one is going to know telemetry is on when you pip install it.

They likely also violate laws and regulations for users falling under GDPR regulation

@MrPowers
Copy link
Collaborator

MrPowers commented Apr 9, 2024

@ion-elgreco - I don't think that non-identifiable data falls under the scope of GDPR.

@jaychia
Copy link

jaychia commented Apr 9, 2024

Hey folks! I'm one of the maintainers of the Daft project, just chiming in here to help clarify some of the work in Daft.

All telemetry collected is non-identifiable, which should not fall in scope of GDPR.

We also noticed that other frameworks which delta-rs already integrates with and currently includes in its documentation also do collect telemetry (though maybe they are not as public as we are so it is less discoverable).

I think that this is important to call out because I wanted to keep discussions on this PR related to the integrations with Daft, and perhaps if the Delta project needs to discuss its stance on its integrations' telemetry policies that can be discussed in a separate thread/issue?

Happy to provide any more clarifications if necessary!

@avriiil
Copy link
Contributor Author

avriiil commented Apr 11, 2024

Hey @ion-elgreco @MrPowers - curious on how we can best proceed here? Would be great to get the integration docs in so that folks who read this new Delta blog can access the relevant documentation :)

@ion-elgreco
Copy link
Collaborator

I would rather see a mention on all these integrations that they collect telemetry which can be opted out from, just a small note at the bottom..

@avriiil
Copy link
Contributor Author

avriiil commented Apr 12, 2024

@ion-elgreco - that seems fine to me. Perhaps out of scope for this PR since it will affect the docs for the other integration techs too?

@avriiil
Copy link
Contributor Author

avriiil commented Apr 12, 2024

@ion-elgreco I've gone ahead and added a note at the end. LMK what you think :)

@ion-elgreco ion-elgreco enabled auto-merge (squash) April 12, 2024 21:13
ion-elgreco
ion-elgreco previously approved these changes Apr 12, 2024
auto-merge was automatically disabled April 12, 2024 21:25

Head branch was pushed to by a user without write access

@avriiil
Copy link
Contributor Author

avriiil commented Apr 12, 2024

Thanks for your help getting this through @ion-elgreco!

@ion-elgreco ion-elgreco merged commit d49d95b into delta-io:main Apr 13, 2024
46 checks passed
@avriiil avriiil deleted the docs-daft-integration branch April 15, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants