chore!: replace rusoto with AWS SDK #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
mightyshazam
changed the title
|
Exciting! thanks for taking this on @mightyshazam , I'll take a more in depth look tomorrow during a commute 🚌 |
|
@rtyler Looks like I may have overlooked some elements. I was trying to do this without updating the logstorefactory trait to require async, but now I'm not seeing a good way around it. |
auto-merge was automatically disabled
March 7, 2024 01:59
Rebase failed
auto-merge was automatically disabled
March 7, 2024 17:23
Rebase failed
|
I will handle rebasing this, some of the rebase conflicts are due to other code which I helped bring in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes rusoto from the AWS crate while adding a dependency to the Rust AWS SDK
Related Issue(s)
#2210
Documentation