Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixing example in CONTRIBUTING.md #2224

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

asura-io
Copy link

Description

The current example rust tests do not work:

$ cargo run --examples basic_operations

error: unexpected argument '--examples' found

  tip: a similar argument exists: '--example'

Usage: cargo run --example [<NAME>] [args]...

For more information, try '--help'.

This also does not work:

$ cargo run --example basic_operations 
error: target `basic_operations` in package `deltalake` requires the features: `datafusion`
Consider enabling them by passing, e.g., `--features="datafusion"`

This does work:

$ cargo run --example basic_operations --features="datafusion"
   Compiling deltalake-core v0.17.0 (/Users/gautham/src/delta-rs/crates/core)
...
...

Making a quick update to the docs so that the example works out of the box.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 27, 2024
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@rtyler rtyler changed the title docs: Fixing example in CONTRIBUTING.md docs: fixing example in CONTRIBUTING.md Feb 27, 2024
@rtyler rtyler enabled auto-merge (rebase) February 27, 2024 15:11
@rtyler rtyler disabled auto-merge February 27, 2024 15:23
@rtyler rtyler enabled auto-merge (rebase) February 27, 2024 15:23
@rtyler rtyler disabled auto-merge February 27, 2024 15:23
@rtyler rtyler merged commit 68f61bf into delta-io:main Feb 27, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants