fix: prevent empty stats struct during parquet write #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwilcoxson-rel
requested review from
wjones127,
roeap and
rtyler
as code owners
rtyler
approved these changes
Jan 27, 2024
RobinLin666
pushed a commit
to RobinLin666/delta-rs
that referenced
this pull request
Feb 2, 2024
# Description
When building the arrow schema for delta checkpoints, List, Map, and
Binary max/min stats are not collected. If you have a Struct column with
only a List Map, or Binary field, then the arrow schema gets an empty
Struct. Parquet writer fails with this:
```
ParquetParseError { source: ArrowError("Parquet does not support writing empty structs") }
```
rtyler
added a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building the arrow schema for delta checkpoints, List, Map, and Binary max/min stats are not collected. If you have a Struct column with only a List Map, or Binary field, then the arrow schema gets an empty Struct. Parquet writer fails with this: