Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust, python): add drop constraint operation #2071

Merged
merged 20 commits into from
Feb 27, 2024
Merged

feat(rust, python): add drop constraint operation #2071

merged 20 commits into from
Feb 27, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

Adds drop constraint as an operation, and also exposed it to python under the alter namespace 😄

Related Issue(s)

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate crate/core labels Jan 13, 2024
@ion-elgreco
Copy link
Collaborator Author

@hntd187 do you want to review this one?

@ion-elgreco ion-elgreco force-pushed the feat/add_drop_constraint branch 2 times, most recently from ea9546a to 069e912 Compare February 1, 2024 09:14
roeap
roeap reviewed Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, left a few mostly style related comments.

crates/core/src/operations/drop_constraints.rs Outdated Show resolved Hide resolved
crates/core/src/operations/drop_constraints.rs Outdated Show resolved Hide resolved
crates/core/src/operations/drop_constraints.rs Outdated Show resolved Hide resolved
python/Cargo.toml Outdated Show resolved Hide resolved
@ion-elgreco
Copy link
Collaborator Author

@roeap thanks for the feedback! I've resolved the comments

hntd187
hntd187 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@hntd187 hntd187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

rtyler
rtyler reviewed Feb 24, 2024
View reviewed changes
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change and then we're ready to roll 🎸

crates/core/src/operations/mod.rs Show resolved Hide resolved
@rtyler rtyler self-assigned this Feb 24, 2024
@rtyler rtyler modified the milestones: python v0.20, Rust v0.18 Feb 24, 2024
@ion-elgreco ion-elgreco enabled auto-merge (squash) February 24, 2024 19:36
@github-actions GitHub Actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@ion-elgreco ion-elgreco merged commit 7f0454e into delta-io:main Feb 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hntd187 hntd187 hntd187 approved these changes

@rtyler rtyler rtyler approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

Assignees

@rtyler rtyler

Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Milestone
Rust v1.0.0
Development

Successfully merging this pull request may close these issues.

Add drop constraint
4 participants
@ion-elgreco @rtyler @hntd187 @roeap