chore: update runs-on value in python_release.yml #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
wjones127
commented
Dec 5, 2023
Comment on lines
-42
to
-49
| # We use extra recent Cargo.toml syntax, so we need at least Rust 1.71.0 | ||
| - name: Install newer rust | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: default | ||
| toolchain: stable | ||
| override: true | ||
|
|
There was a problem hiding this comment.
Newer runner has Rust 1.73.0: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#rust-tools
wjones127
commented
Dec 5, 2023
| - name: Publish to pypi (without sdist) | ||
| uses: messense/maturin-action@v1 | ||
| env: | ||
| MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }} | ||
| with: | ||
| target: ${{ matrix.target }} | ||
| command: publish | ||
| args: -m python/Cargo.toml --no-sdist ${{ env.FEATURES_FLAG }} | ||
|
|
||
| release-pypi-mac-universal2: |
There was a problem hiding this comment.
I don't think anyone really has need for this.
There was a problem hiding this comment.
What are those feature flags setting there?
There was a problem hiding this comment.
You mean this?
delta-rs/.github/workflows/python_release.yml
Lines 12 to 14 in 573cbd1
ion-elgreco
changed the title
ion-elgreco
previously approved these changes
Dec 5, 2023
ion-elgreco
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Latest Python release had a bunch of failures: https://github.com/delta-io/delta-rs/actions/runs/7095801050
Also doing some general cleanup.
TODO:
Related Issue(s)
Documentation