Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): expose convert_to_deltalake #1842

Merged

Conversation

ion-elgreco
Copy link
Collaborator

@ion-elgreco ion-elgreco commented Nov 12, 2023

Description

Exposes added convert to delta functionality by @junjunjd to Python API.

Related Issue(s)

@github-actions github-actions bot added the binding/python Issues for the Python package label Nov 12, 2023
@ion-elgreco ion-elgreco force-pushed the feat/expose_convert_to_delta_python branch from 8a9a8b9 to ee9e515 Compare November 18, 2023 10:42
@ion-elgreco ion-elgreco marked this pull request as ready for review November 18, 2023 10:42
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Left one small comment to look at.

python/src/lib.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Nov 19, 2023
@ion-elgreco ion-elgreco force-pushed the feat/expose_convert_to_delta_python branch from 49f5d62 to 0153813 Compare November 19, 2023 09:46
roeap
roeap previously approved these changes Nov 19, 2023
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left two more minor suggestions, that you may choose to include or ignore 😄.

crates/deltalake-core/src/operations/convert_to_delta.rs Outdated Show resolved Hide resolved
crates/deltalake-core/src/protocol/mod.rs Outdated Show resolved Hide resolved
@ion-elgreco
Copy link
Collaborator Author

@roeap yeah good one, making input case insensitive!

Btw your approval got dismissed now by committing :😁

@ion-elgreco ion-elgreco enabled auto-merge (squash) November 19, 2023 15:07
@ion-elgreco ion-elgreco merged commit e48b8a7 into delta-io:main Nov 19, 2023
24 checks passed
ion-elgreco added a commit to ion-elgreco/delta-rs that referenced this pull request Nov 20, 2023
Exposes added `convert to delta` functionality by @junjunjd to Python
API.

- closes delta-io#1767

---------

Co-authored-by: Robert Pack <[email protected]>
ion-elgreco added a commit to ion-elgreco/delta-rs that referenced this pull request Nov 20, 2023
Exposes added `convert to delta` functionality by @junjunjd to Python
API.

- closes delta-io#1767

---------

Co-authored-by: Robert Pack <[email protected]>
ion-elgreco added a commit to ion-elgreco/delta-rs that referenced this pull request Nov 20, 2023
Exposes added `convert to delta` functionality by @junjunjd to Python
API.

- closes delta-io#1767

---------

Co-authored-by: Robert Pack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate crate/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose convert_to_delta to Python API
2 participants