feat: initial table features implementation #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # rust/src/operations/create.rs # rust/src/operations/restore.rs # rust/src/operations/transaction/test_utils.rs # rust/src/protocol/checkpoints.rs # rust/src/protocol/mod.rs # rust/src/protocol/parquet2_read/mod.rs # rust/src/protocol/parquet_read/mod.rs # rust/src/table/mod.rs # rust/src/table/state.rs
cmackenzie1
reviewed
Nov 2, 2023
| V2_CHECKPOINT, | ||
| /// If we do not match any other reader features | ||
| #[serde(other)] | ||
| OTHER, |
There was a problem hiding this comment.
Should we capture this value using an untagged variant instead?
Something like this
#[derive(serde::Deserialize, serde::Serialize, Debug, Clone)]
pub enum Example {
Foo,
Bar,
#[serde(untagged)]
Unknown(String),
}
#[derive(serde::Deserialize, serde::Serialize, Debug, Clone)]
struct Features {
reader: Vec<Example>
}
fn main() {
let features = Features {
reader: vec![Example::Foo, Example::Bar, Example::Unknown("Hello".to_string())],
};
println!("{}", serde_json::to_string(&features).unwrap());
let features: Features = serde_json::from_str(r#"{"reader":["Foo","Bar","Hello"]}"#).unwrap();
println!("{:#?}", features);
}There was a problem hiding this comment.
Actually read my mind, I like this more than other.
wjones127
previously approved these changes
Nov 2, 2023
… copy simple table to not fail python tests
auto-merge was automatically disabled
November 2, 2023 21:16
Head branch was pushed to by a user without write access
wjones127
approved these changes
Nov 3, 2023
Merged
natinimni
pushed a commit
to natinimni/delta-rs
that referenced
this pull request
Jan 31, 2024
# Description Hi again, this is table features again, but albeit with less work done on the main branch like the smart guy I am. # Related Issue(s) delta-io#1755 prior review and information # Documentation https://delta.io/blog/2023-07-27-delta-lake-table-features/ https://github.com/delta-io/delta/blob/master/PROTOCOL.md#table-features --------- Co-authored-by: Stephen Carman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi again, this is table features again, but albeit with less work done on the main branch like the smart guy I am.
Related Issue(s)
#1755 prior review and information
Documentation
https://delta.io/blog/2023-07-27-delta-lake-table-features/
https://github.com/delta-io/delta/blob/master/PROTOCOL.md#table-features