fix: delta scan partition ordering bug #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
take |
|
@mightyshazam @MrPowers Why is there a take on this PR? it's mostly done the only things that needs to be done is removing some unwraps. |
|
@Blajda - sorry for the miscommunication. @mightyshazam will help out with a review. I assigned it to him cause I can't assign him as a reviewer, but now realize that was misleading. So yea, let @mightyshazam know when you're done so he can take a look, thanks!! |
|
@MrPowers |
|
@mightyshazam this is ready for review. Thanks for taking the initiative |
mightyshazam
reviewed
Nov 2, 2023
mightyshazam
approved these changes
Nov 2, 2023
mightyshazam
approved these changes
Nov 3, 2023
wjones127
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the order of partition columns in our delta schema does not match the order of partition columns in the deltatable metadata.
This would cause
DeltaScanto provide incorrect values for partition columns.This is fixed by having
DeltaScanuse the metadata as the source of truth.Related Issue(s)
MERGEworks incorrectly with partitioned table if the data column order is not same as table column order #1787