perf: avoid holding GIL in DeltaFileSystemHandler #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
wjones127
changed the title
wjones127
changed the title
wjones127
force-pushed
the
filesystem-performance
branch
from
ec1c5c6
to
8892d20
Compare
wjones127
requested review from
fvaleye,
rtyler,
roeap,
houqp,
xianwill and
mosyp
as code owners
rtyler
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure yet this is the root cause of the performance issues we are seeing in #1569, but this seems like an obvious change that might help.
Any method that takes
&mut selfimplicitly holds the GIL, so we'll need to allow threads explicitly in those methods.Related Issue(s)
Documentation