-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: port docs to mkdocs #1548
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
You can build the new docs and run them locally with The new docs look quite similar to the existing docs, but they're easier to navigate and have a URL structure that's better for SEO. |
Not sure if there has been much discussion around hosting the site but I'd be happy to help setup Cloudflare Pages (disclaimer, I work at Cloudfare) |
@cmackenzie1 - thanks for the offer. I think the original idea was to just use GitHub pages and the same URL where the current docs are hosted: https://delta-io.github.io/delta-rs/python/ I am open to other ideas from the community of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrPowers since this is at the root of the tree and not in the python/
directory. Is this where I can start landing some Rust documentation as well? I have been pining to improve the documentation situation there lately as well
@rtyler - yea, would be great to use this as an opportunity to improve the Rust documentation as well. Here is how Polars organizes their URLs:
The user guide has tabbed code blocks to switch between languages: Would you be OK if we organize the delta-rs documentation in a similar manner? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is coming into the root of the tree and is not yet published anywhere. I want to merge this and continue collaborating around it.
+1. I started looking into adding Python API reference to this, but it turns out it will require quite a few fixes to our type stubs, so it's best this happens in a new PR. |
Description
This PR ports the docs to mkdocs. We'd like to be able to write docs in Markdown.
A previous PR ported the docs to mkBook, but we think mkdocs is better, so the mkBook PR will be closed.
Related Issue(s)
n/a
Documentation
n/a