Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert premature merge of an attempted fix for binary column statistics #1544

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Jul 19, 2023

Mea culpa regarding #1498

…error (delta-io#1498)"

This reverts commit 312d1c2.

I should not have merged this, I must have mistaken the red ❌
pull request delta-io#1498 for something else when I merged. This backs out that commit
@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels Jul 19, 2023
@github-actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@rtyler rtyler changed the title fix: Revert premature merge of an attempted fix for binary column statistics fix: revert premature merge of an attempted fix for binary column statistics Jul 19, 2023
@rtyler rtyler marked this pull request as ready for review July 19, 2023 06:23
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@rtyler rtyler enabled auto-merge (rebase) July 19, 2023 06:26
@rtyler rtyler merged commit a7389d5 into delta-io:main Jul 19, 2023
@rtyler rtyler deleted the revert-binary-column-stats branch July 19, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants