Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify with_predicate for delete ops #1512

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

Blajda
Copy link
Collaborator

@Blajda Blajda commented Jul 4, 2023

Description

A small refactor on the delete op to have the same interface as the update op

Allows a single method to be used for predicates represented as an Datafusion Expr or as a string.

@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels Jul 4, 2023
@Blajda Blajda marked this pull request as ready for review July 4, 2023 02:24
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement - thanks @Blajda!

@roeap roeap merged commit 5172dd6 into delta-io:main Jul 6, 2023
@Blajda Blajda deleted the delete-refactor branch July 10, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants