-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): expose WriterProperties method on RecordBatchWriter and DeltaWriter #1497
feat(rust): expose WriterProperties method on RecordBatchWriter and DeltaWriter #1497
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
This is my first time contributing to a Rust repo so happy for any and all feedback and to be told I am on the completely wrong path. |
Not sure why the python lint is suddenly not passing... Seems to be a mypy issue with a |
@theelderbeever don't worry about the mypy. It's from a new version of the checker. I have a fix in another PR, so that'll be green once that PR is merged. |
@wjones127 Gotcha makes sense. I can revert my last commit that adds the ignore flag then. |
This reverts commit e65f831.
aaf39f3
to
ad6c8f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this to the example :)
Description
Adds the capability to pass a configured WriterProperties to the
RecordBatchWriter
andDeltaWriter
similar to how theOptimizeBuilder
can be updated.Related Issue(s)
Documentation