-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove LoadCheckpointError
and ApplyLogError
#1432
Conversation
f8c10c4
to
b08c00f
Compare
LoadCheckpointError
LoadCheckpointError
and ApplyLogError
Co-authored-by: Cole Mackenzie <[email protected]>
@cmackenzie1 - do you have an opinion on the general direction where this is headed? I.e. the way I see it right now, we would end up with a single top level error and everyting in delta-rs just returns a |
@roeap I think that sounds great. Right now there are a few things that return different errors so you can't use Is there the possibility to create a class of errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems reasonable :)
Description
This PR removes
LoadCheckpointError
andApplyLogError
as well as moves some more checkpoint related functions into the checkpoint module.Aside from cleaning up errors, this moves us a little bit closer to isolating log handling related logic in preparation for some upcoming work.
Related Issue(s)
part of: #1136