Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove LoadCheckpointError and ApplyLogError #1432

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Jun 4, 2023

Description

This PR removes LoadCheckpointError and ApplyLogError as well as moves some more checkpoint related functions into the checkpoint module.

Aside from cleaning up errors, this moves us a little bit closer to isolating log handling related logic in preparation for some upcoming work.

Related Issue(s)

part of: #1136

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate rust labels Jun 4, 2023
@roeap roeap changed the title refactor: remove LoadCheckpointError refactor: remove LoadCheckpointError and ApplyLogError Jun 4, 2023
python/src/error.rs Outdated Show resolved Hide resolved
Co-authored-by: Cole Mackenzie <[email protected]>
@roeap
Copy link
Collaborator Author

roeap commented Jun 5, 2023

@cmackenzie1 - do you have an opinion on the general direction where this is headed? I.e. the way I see it right now, we would end up with a single top level error DeltaError, Underneath that we would have one level more of delta specific error like ProtocolError or CommitConflictError, where we try to give specific the user may wnat to react on. Things like object store errors etc would still be surfaced similar to what we do now.

and everyting in delta-rs just returns a DeltaError ...

@cmackenzie1
Copy link
Contributor

and everyting in delta-rs just returns a DeltaError ...

@roeap I think that sounds great. Right now there are a few things that return different errors so you can't use ? if they are in the same scope.

Is there the possibility to create a class of errors Retryable? Things for transient errors like 5xx from object stores?

Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable :)

@roeap roeap merged commit 2db7f9b into delta-io:main Jun 6, 2023
@roeap roeap deleted the remove-checkpoint-error branch June 6, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants