fix: update cleanup regex to include checkpoint.parquet files
#1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously, if a table had no new commits but log_retention_expiry lapsed for the latest commit or checkpoint file, the file would be removed leaving the table in a corrupted state. To prevent this, cleanup_metadata should only run with `current_version` equal to the table states current version. For example, `cleanup_metadata` for v10 would only touch files for v0-v9.
cmackenzie1
force-pushed
the
cole/issue-1420
branch
from
3dda954
to
5e2eeae
Compare
cmackenzie1
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
rtyler
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update cleanup regex to include
checkpoint.parquetfilesRelated Issue(s)
cleanup_metadatadoesn't remove.checkpoint.parquetfiles #1420Documentation
https://regex101.com/r/OmoZMz/2