perf: improve record batch partitioning #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
rtyler and
mosyp
as code owners
rtyler
reviewed
May 27, 2023
| @@ -410,6 +403,18 @@ pub(crate) fn divide_by_partition_values( | |||
| Ok(partitions) | |||
| } | |||
|
|
|||
| fn lexsort_to_indices(arrays: &[ArrayRef]) -> UInt32Array { | |||
There was a problem hiding this comment.
I am not following why this function is being used here instead of the previous import from arrow::compute as far as I can tell the only difference is this version doesn't take the optional limit parameter?
😕
There was a problem hiding this comment.
This version uses arrow-row rather then the "regular" compute kernels. https://github.com/apache/arrow-rs/blob/77aa8f5b2645a91724048f5c1d644c6b52880028/arrow-ord/src/sort.rs#L1081-L1082
the implementation is actually lifted from a comment in the docs :) https://github.com/apache/arrow-rs/blob/77aa8f5b2645a91724048f5c1d644c6b52880028/arrow-row/src/lib.rs#L105-L117
rtyler
approved these changes
May 28, 2023
| @@ -410,6 +403,18 @@ pub(crate) fn divide_by_partition_values( | |||
| Ok(partitions) | |||
| } | |||
|
|
|||
| fn lexsort_to_indices(arrays: &[ArrayRef]) -> UInt32Array { | |||
There was a problem hiding this comment.
Suggested change
| fn lexsort_to_indices(arrays: &[ArrayRef]) -> UInt32Array { | |
| /* | |
| * This version uses arrow-row rather then the "regular" compute kernels. | |
| */ | |
| fn lexsort_to_indices(arrays: &[ArrayRef]) -> UInt32Array { |
roeap
added a commit
to roeap/delta-rs
that referenced
this pull request
Jun 2, 2023
# Description Some time ago, the arrow-row crate was published, specifically with use cases like multi-column ordering / sorting in mind. We need to do this whenever we write data to a table to partition batches according to their partition values. In this PR we adopt this. As a drive-by I also updated the imports in the module to import from the respective sub-crates. # Related Issue(s) <!--- For example: - closes #106 ---> # Documentation <!--- Share links to useful documentation --->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some time ago, the arrow-row crate was published, specifically with use cases like multi-column ordering / sorting in mind. We need to do this whenever we write data to a table to partition batches according to their partition values. In this PR we adopt this. As a drive-by I also updated the imports in the module to import from the respective sub-crates.
Related Issue(s)
Documentation