fix: add conversion for string for Field::TimestampMicros (#1372)
#1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cros` Add a match statement to handle the case when timestamp is encoded as `TimestampMicros` in the parquet file. Resolves delta-io#1372.
cmackenzie1
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cmackenzie1
commented
May 16, 2023
| .timestamp_opt(seconds, microseconds * 1_000) | ||
| .single() | ||
| .ok_or("Value out of bounds")?; | ||
| Ok(dt.to_rfc3339_opts(SecondsFormat::Micros, true)) |
There was a problem hiding this comment.
Do we want SecondsFormat::Micros here or match with Millisecond format as above?
There was a problem hiding this comment.
Seems like micros is fine. Spec specifically allows that one. https://github.com/delta-io/delta/blob/master/PROTOCOL.md#partition-value-serialization
wjones127
approved these changes
May 17, 2023
roeap
changed the title
Field::TimestampMicrosField::TimestampMicros (#1372)
roeap
changed the title
Field::TimestampMicros (#1372)Field::TimestampMicros (#1372)
roeap
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a match statement to handle the case when timestamp is encoded as
TimestampMicrosin the parquet file.Related Issue(s)
Documentation
N/A