fix: add py.typed marker #1350
Merged
fix: add py.typed marker #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchutteJan
requested review from
wjones127,
fvaleye,
rtyler,
roeap and
houqp
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
Thanks @SchutteJan 👍 |
fvaleye
approved these changes
May 9, 2023
wjones127
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that our mypy evaluation was failing upon importing
deltalakepackage due to missingpy.typedmarker or a stubs package. Given there is type information already annotated in this repo, it makes sense for the python package to be PEP-561 compatible.Maturin should pick this file up and distribute it correctly, according to the documentation
Related Issue(s)
No open issues (I could find)
Documentation
https://peps.python.org/pep-0561/#packaging-type-information
https://www.maturin.rs/project_layout.html?highlight=py.typ#adding-python-type-information