Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the json feature for the parquet crate #1300

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Enable the json feature for the parquet crate #1300

merged 1 commit into from
Apr 20, 2023

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Apr 19, 2023

This feature makes it much easier to read/write JSON to parquet. This is immediately useful in kafka-delta-ingest but I believe will be much more generally useful for all consumers of the package

@rtyler
Enable the json feature for the parquet crate
87cc9de 
This feature makes it much easier to read/write JSON to parquet. This is
immediately useful in kafka-delta-ingest but I believe will be much more
generally useful for all consumers of the package
@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels Apr 19, 2023
@rtyler rtyler marked this pull request as ready for review April 19, 2023 03:39
@rtyler rtyler enabled auto-merge (rebase) April 19, 2023 03:39
houqp
houqp approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to turn it into an optional feature so downstream consumers can opt out if they don't need to pull in all the json serde code.

@rtyler rtyler merged commit fb7aefd into delta-io:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houqp houqp houqp approved these changes

@xianwill xianwill Awaiting requested review from xianwill

@wjones127 wjones127 Awaiting requested review from wjones127

@fvaleye fvaleye Awaiting requested review from fvaleye

@roeap roeap Awaiting requested review from roeap

@mosyp mosyp Awaiting requested review from mosyp

Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtyler @houqp