improve debuggability of json ser/de errors #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
requested review from
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
houqp
commented
Feb 5, 2023
| @@ -332,6 +332,25 @@ impl MetaData { | |||
| } | |||
| } | |||
|
|
|||
| impl TryFrom<DeltaTableMetaData> for MetaData { | |||
There was a problem hiding this comment.
drive by refactor, makes more sense to keep all MetaData impl in the same place.
|
Looks like the python azure test has flaky timeout errors. |
wjones127
approved these changes
Feb 11, 2023
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
# Description
JSON serde errors are very hard to debug because they are usually
displayed with the following vague error messages:
```
Error: Invalid JSON in log record: EOF while parsing a value at line 1 column 1
Caused by:
EOF while parsing a value at line 1 column 1
```
This PR separates JSON ser/de errors by different scenarios as well as
adding more context to each error whenever applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JSON serde errors are very hard to debug because they are usually displayed with the following vague error messages:
This PR separates JSON ser/de errors by different scenarios as well as adding more context to each error whenever applicable.