fix: datafusion predicate pushdown and dependencies #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
wjones127,
fvaleye,
rtyler,
houqp,
xianwill and
mosyp
as code owners
roeap
force-pushed
the
datafusion-update
branch
from
1122e59
to
a3e9786
Compare
houqp
approved these changes
Jan 16, 2023
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update datafusion to version 16 and arrow to corresponding version 29. This also fixes a logical error in predicate pushdown and implements missing methods on
TableProvider, specifically also the one telling datafusion that predicate pushdown is supported :).Turns out, our tests already cover that predicates are working correctly, when actually being used.
Related Issue(s)
closes #1063
closes #1064
Documentation