feat: enable passing storage options to Delta table builder via DataFusion's CREATE EXTERNAL TABLE #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gh the CREATE EXTERNAL TABLE command
…via the CREATE EXTERNAL TABLE command
gruuya
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
gruuya
changed the title
gruuya
changed the title
houqp
previously approved these changes
Dec 30, 2022
|
Thanks @gruuya , very cool feature. Looks like the test refactor broke some of the tests, could you fix that? |
|
Thanks, sure thing! I realized that I tested the refactored |
wjones127
approved these changes
Dec 30, 2022
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
…usion's CREATE EXTERNAL TABLE (delta-io#1043) # Description We've recently added Delta table support to [Seafowl](https://github.com/splitgraph/seafowl) using delta-rs, which utilizes the new `OPTIONS` clause in sqlparser/DataFusion. It allows propagating a set of key/values down to the `DeltaTableBuilder`, which in turn can use those to instantiate a corresponding object store client. This means someone can now define a delta table without relying on env vars as: ```sql CREATE EXTERNAL TABLE my_delta STORED AS DELTATABLE OPTIONS ('AWS_ACCESS_KEY_ID' 'secret', 'AWS_SECRET_ACCESS_KEY' 'also_secret', 'AWS_REGION' 'eu-west-3') LOCATION 's3://my-bucket/my-delta-table/' ``` I've also changed the existing datafusion integration tests to use this approach to exercise it. I'm not sure whether it makes sense to merge this PR upstream, but opening this PR just in case it does. # Related Issue(s) Didn't find any related issues. # Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've recently added Delta table support to Seafowl using delta-rs, which utilizes the new
OPTIONSclause in sqlparser/DataFusion. It allows propagating a set of key/values down to theDeltaTableBuilder, which in turn can use those to instantiate a corresponding object store client. This means someone can now define a delta table without relying on env vars as:I've also changed the existing datafusion integration tests to use this approach to exercise it.
I'm not sure whether it makes sense to merge this PR upstream, but opening this PR just in case it does.
Related Issue(s)
Didn't find any related issues.
Documentation