-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DataFusion 15 #1021
Support DataFusion 15 #1021
Conversation
6f44aa6
to
2077b38
Compare
Hi @andrei-ionescu thanks for the contribution, in this case unfortunately there already is a PR open for this :) #1014 |
@roeap since this pull request is smaller and more isolated from other changes, is there a problem with working to bring this in? That would allow us to evaluate the non-string partition changes more independent of the datafusion changes |
@rtyler - certainly, whatever gets us there quickest :). @andrei-ionescu - In order to make the tests pass, we need to update the schema validation in the |
2077b38
to
8ff24a8
Compare
Thanks @andrei-ionescu, excellent work!. The python 3.10 test is in fact flaky and not caused by this PR. One last ask, there is a test for the new type handling in datafusion 15 in the other PR. As we do the migration here, could you move the test as well? Otherwise looks great and we should be able to merge before #971 happens. |
@roeap Thanks for the suggestion with the test. Added it into here. |
@andrei-ionescu thanks for adding the test - looks great! - It seems thought that a single dev artifact slipped into the code. There is a new parquet file in a new |
eb73948
to
0d41c8b
Compare
@roeap: You're right! I may have been running a cargo command on the root of the project that created that I did not noticed it in the PR. Sorry for that! I removed it. |
Looking good - waiting for CI to finish and we are ready to merge :) |
Description
Add support for DataFusion 15.
Upgrades dependencies:
DataFusion
from14
to15
Arrow
from26
to28
Related Issue(s)
Documentation