Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DataFusion 15 #1021

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Conversation

andrei-ionescu
Copy link
Contributor

Description

Add support for DataFusion 15.

Upgrades dependencies:

  • DataFusion from 14 to 15
  • Arrow from 26 to 28

Related Issue(s)

Documentation

@roeap
Copy link
Collaborator

roeap commented Dec 15, 2022

Hi @andrei-ionescu thanks for the contribution, in this case unfortunately there already is a PR open for this :) #1014

@rtyler
Copy link
Member

rtyler commented Dec 16, 2022

@roeap since this pull request is smaller and more isolated from other changes, is there a problem with working to bring this in? That would allow us to evaluate the non-string partition changes more independent of the datafusion changes

rust/src/delta_datafusion.rs Outdated Show resolved Hide resolved
rust/src/delta_datafusion.rs Outdated Show resolved Hide resolved
rust/src/delta_datafusion.rs Outdated Show resolved Hide resolved
rust/src/delta_arrow.rs Outdated Show resolved Hide resolved
rust/src/delta_arrow.rs Outdated Show resolved Hide resolved
@roeap
Copy link
Collaborator

roeap commented Dec 16, 2022

@rtyler - certainly, whatever gets us there quickest :).

@andrei-ionescu - In order to make the tests pass, we need to update the schema validation in the operations/writer file as well. you can look at #1014 to see one option to do this.

@andrei-ionescu
Copy link
Contributor Author

@roeap, @rtyler, I implemented the suggested feedback. Thanks for giving the me hint about #1014 PR.

All checks did pass except the "Python 3.10 PyArrow latest" step. It seems that it did timeout. Do you know the root cause of this? Is it transient?

@roeap
Copy link
Collaborator

roeap commented Dec 16, 2022

Thanks @andrei-ionescu, excellent work!. The python 3.10 test is in fact flaky and not caused by this PR.

One last ask, there is a test for the new type handling in datafusion 15 in the other PR. As we do the migration here, could you move the test as well? Otherwise looks great and we should be able to merge before #971 happens.

@andrei-ionescu
Copy link
Contributor Author

@roeap Thanks for the suggestion with the test. Added it into here.

@andrei-ionescu andrei-ionescu requested review from roeap and removed request for rtyler, xianwill, houqp, wjones127, mosyp and fvaleye December 16, 2022 15:58
@roeap
Copy link
Collaborator

roeap commented Dec 16, 2022

@andrei-ionescu thanks for adding the test - looks great! - It seems thought that a single dev artifact slipped into the code. There is a new parquet file in a new data/ folder within in root of the repo, that i cannot place.

@andrei-ionescu
Copy link
Contributor Author

@roeap: You're right! I may have been running a cargo command on the root of the project that created that I did not noticed it in the PR. Sorry for that! I removed it.

@roeap
Copy link
Collaborator

roeap commented Dec 16, 2022

Looking good - waiting for CI to finish and we are ready to merge :)

@roeap roeap merged commit bd8db74 into delta-io:main Dec 16, 2022
@andrei-ionescu andrei-ionescu deleted the support_datafusion_15 branch December 16, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Apache Arrow DataFusion 15
3 participants