Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement restore command #837

Closed
wjones127 opened this issue Sep 23, 2022 · 7 comments
Closed

Implement restore command #837

wjones127 opened this issue Sep 23, 2022 · 7 comments
Labels
binding/rust Issues for the Rust crate enhancement New feature or request good first issue Good for newcomers

Comments

@wjones127
Copy link
Collaborator

Description

This is another easy to implement command that shouldn't require writing data files. It makes the history command much more useful!

See docs: https://docs.databricks.com/delta/delta-utility.html#restore-delta-table

Use Case

Related Issue(s)
@wjones127 wjones127 added enhancement New feature or request good first issue Good for newcomers binding/rust Issues for the Rust crate labels Sep 23, 2022
@Bernolt
Copy link
Contributor

Bernolt commented Nov 1, 2022

Hello,
I will start working on this.
I will use a similar approach as for Vacuum implementation.

@roeap
Copy link
Collaborator

roeap commented Nov 10, 2022

Hi @Bernolt - there is a PR open (#852) which will intorduce some changes to the operations APIs. It is similar to the way how vacuum is implemented right now, but leverages the IntoFuture trait stabilized in 1.64. Not sure how far along you are, but if still feasible maybe consider this :).

@loleek
Copy link
Contributor

loleek commented May 17, 2023

Is this issue still available?

@wjones127
Copy link
Collaborator Author

Yes, we haven't gotten a PR for this yet, but would be happy to review one. I haven't heard from Bernolt recently.

@loleek
Copy link
Contributor

loleek commented May 17, 2023

OK.I will look into it and try to file a PR.

@loleek
Copy link
Contributor

loleek commented Jun 25, 2023

Been busy with other things lately, now back to this feature. I've already read delta's implement, and will try to file recent days.

loleek added a commit to loleek/delta-rs that referenced this issue Jun 29, 2023
@loleek
feat: implement resotre operation (delta-io#837)
d390954
@loleek loleek mentioned this issue Jun 29, 2023
Merged
loleek added a commit to loleek/delta-rs that referenced this issue Jun 29, 2023
@loleek
feat: implement restore operation (delta-io#837)
fcb5650
loleek added a commit to loleek/delta-rs that referenced this issue Jun 30, 2023
@loleek
feat: implement restore operation (delta-io#837)
3a412a0
loleek added a commit to loleek/delta-rs that referenced this issue Jun 30, 2023
@loleek
feat: implement restore operation (delta-io#837)
210c9b6
loleek added a commit to loleek/delta-rs that referenced this issue Jul 4, 2023
@loleek
feat: implement restore operation (delta-io#837)
310524a
roeap pushed a commit that referenced this issue Jul 4, 2023
@loleek
feat: implement restore operation (#1502)
6650bd2 
# Description
This is a implementation of the Restore Command.

# Related Issue(s)
#837
@loleek loleek mentioned this issue Jul 11, 2023
Merged
wjones127 added a commit that referenced this issue Aug 1, 2023
@loleek @wjones127
feat: add restore command in python binding (#1529)
2210c3b 
# Description
This is a implementation of the Restore Command for python binding.

# Related Issue(s)
#837

---------

Co-authored-by: Will Jones <[email protected]>
polynomialherder pushed a commit to polynomialherder/delta-rs that referenced this issue Aug 15, 2023
@loleek @wjones127 @polynomialherder
feat: add restore command in python binding (delta-io#1529)
b7a5a0c 
# Description
This is a implementation of the Restore Command for python binding.

# Related Issue(s)
delta-io#837

---------

Co-authored-by: Will Jones <[email protected]>
@ion-elgreco
Copy link
Collaborator

@wjones127 it's available in rust and python now, so we can close it :)

@houqp houqp closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@houqp @Bernolt @wjones127 @loleek @ion-elgreco @roeap