Move fn to DeltaTable, replace match with Ok

delta-io · Jul 31, 2024 · 6f6769d · 6f6769d
1 parent ceeffd8
commit 6f6769d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/crates/core/src/table/builder.rs b/crates/core/src/table/builder.rs
@@ -330,12 +330,6 @@ impl DeltaTableBuilder {
         }
         Ok(table)
     }
-
-    /// Check if the [`DeltaTable`] exists
-    pub async fn verify_deltatable_existence(self) -> DeltaResult<bool> {
-        let table = self.build()?;
-        table.log_store.is_delta_table_location().await
-    }
 }
 
 enum UriType {

diff --git a/crates/core/src/table/mod.rs b/crates/core/src/table/mod.rs
@@ -287,6 +287,11 @@ impl DeltaTable {
         self.log_store.object_store()
     }
 
+    /// Check if the [`DeltaTable`] exists
+    pub async fn verify_deltatable_existence(&self) -> DeltaResult<bool> {
+        self.log_store.is_delta_table_location().await
+    }
+
     /// The URI of the underlying data
     pub fn table_uri(&self) -> String {
         self.log_store.root_uri()

diff --git a/python/src/lib.rs b/python/src/lib.rs
@@ -146,14 +146,14 @@ impl RawDeltaTable {
         if let Some(storage_options) = storage_options {
             builder = builder.with_storage_options(storage_options)
         }
-        let res = rt()
-            .block_on(builder.verify_deltatable_existence())
-            .map_err(PythonError::from);
-        match res {
-            Ok(true) => Ok(true),
-            Ok(false) => Ok(false),
-            Err(err) => Err(err)?,
-        }
+        Ok(rt()
+            .block_on(async {
+                match builder.build() {
+                    Ok(table) => table.verify_deltatable_existence().await,
+                    Err(err) => Err(err),
+                }
+            })
+            .map_err(PythonError::from)?)
     }
 
     pub fn table_uri(&self) -> PyResult<String> {