move transaction module into actions/ and rename to set_transaction
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachschuermann
requested review from
nicklan,
scovich,
hntd187 and
scottsand-db
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=======================================
Coverage 77.68% 77.69%
=======================================
Files 49 49
Lines 10084 10087 +3
Branches 10084 10087 +3
=======================================
+ Hits 7834 7837 +3
Misses 1805 1805
Partials 445 445 ☔ View full report in Codecov by Sentry. |
nicklan
requested changes
Oct 9, 2024
scottsand-db
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
LGTM. This brings the name of the "transaction" ("txn") Delta protocol action to be en-par with how Delta-Kernel-API and Delta-Spark refer to it as in the code, a SetTransaction. That name is a signification improvement over "Transaction", and the unification between the kernels is also great.
Co-authored-by: Nick Lanham <[email protected]>
Co-authored-by: Nick Lanham <[email protected]>
github-actions
bot
added
the
breaking-change
15 tasks
scovich
approved these changes
Oct 14, 2024
zachschuermann
added a commit
that referenced
this pull request
Oct 25, 2024
…tion (#370) This PR does 4 main things: 1. ~reorganize `transaction.rs` so that the transaction action is now moved to actions module~ **EDIT:** now in #386 1. new `Transaction` API which includes: a. `Table.new_transaction()` to create a new transaction from the latest snapshot of the table b. `Transaction.with_commit_info(engine_commit_info: Box<dyn EngineData>)` to add single-row commit info in the form of a `map<string, string>`. required to commit. c. `Transaction.with_operation(operation: String)` to set the operation name of the transaction (persisted in commit info) d. `Transaction.commit() // consumes transaction` to commit the transaction to the log (currently only supporting committing the commit info) 1. new engine API: `write_json_file(impl Iterator<Item = Box<dyn EngineData>>)` (and a default engine implementation for this) 1. new integration test suite `write.rs` to house many of our write tests as it's implemented resolves #378 --------- Co-authored-by: Ryan Johnson <[email protected]> Co-authored-by: Nick Lanham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefactor for write-path work. this does three things
set_transactionandTransactiontoSetTransactioncommitInfoto actions schema and define a commit info object which (for now) just includes kernel version