Add visitor for converting kernel expressions to engine expressions

.github/workflows/build.yml

@@ -86,6 +86,7 @@ jobs:
               sudo apt update
               sudo apt install -y -V libarrow-dev # For C++
               sudo apt install -y -V libarrow-glib-dev # For GLib (C)
+              sudo apt install -y -V valgrind # For memory leak test
           elif [ "$RUNNER_OS" == "macOS" ]; then
               brew install apache-arrow
               brew install apache-arrow-glib
@@ -108,16 +109,24 @@ jobs:
           cargo build
           popd
           pushd ffi
-          cargo b --features default-engine,sync-engine
+          cargo b --features default-engine,sync-engine,test-ffi
           popd
-      - name: build and run test
+      - name: build and run read-table test
         run: |
           pushd ffi/examples/read-table
           mkdir build
           pushd build
           cmake ..
           make
           make test
+      - name: build and run visit-expression test
+        run: |
+          pushd ffi/examples/visit-expression
+          mkdir build
+          pushd build
+          cmake ..
+          make
+          make test
 
   coverage:
     runs-on: ubuntu-latest

ffi/Cargo.toml

@@ -47,3 +47,4 @@ default-engine = [
 ]
 sync-engine = ["delta_kernel/sync-engine"]
 developer-visibility = []
+test-ffi = []

ffi/examples/visit-expression/CMakeLists.txt

@@ -0,0 +1,33 @@
+cmake_minimum_required(VERSION 3.12)
+project(visit_expressions)
+
+add_executable(visit_expression visit_expression.c)
+target_compile_definitions(visit_expression PUBLIC DEFINE_DEFAULT_ENGINE)
+target_include_directories(visit_expression PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/../../../target/ffi-headers")
+target_link_directories(visit_expression PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/../../../target/debug")
+target_link_libraries(visit_expression PUBLIC delta_kernel_ffi)
+target_compile_options(visit_expression PUBLIC)
+
+target_compile_options(visit_expression PRIVATE -Wall -Wextra -Wpedantic -Werror -Wno-strict-prototypes)
+
+# Get info on the OS and platform
+if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
+    set(MACOSX TRUE)
+endif()
+if(UNIX AND NOT APPLE)
+    set(LINUX TRUE)
+endif()
+
+# Add the kernel expresion -> engine expression test
+include(CTest)
+set(ExprTestRunner "../../../tests/test-expression-visitor/run_test.sh")
+set(ExprExpectedPath "../../../tests/test-expression-visitor/expected.txt")
+add_test(NAME test_expression_visitor COMMAND ${ExprTestRunner} ${ExprExpectedPath})
+if(LINUX)
+  add_test(NAME test_expression_visitor_leaks COMMAND valgrind
+    --error-exitcode=1
+    --tool=memcheck
+    --leak-check=full
+    --errors-for-leak-kinds=definite
+    --show-leak-kinds=definite ./visit_expression)
+endif()