Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try it out for windows #293

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

try it out for windows #293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ec4b2b
try it out for windows
nicklan Jul 24, 2024
77f2ceb
force use bash
nicklan Jul 24, 2024
c2bac2e
install arrow in msys2 step
nicklan Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,21 @@ jobs:
os:
- macOS-latest
- ubuntu-latest
- windows-latest
steps:
- uses: actions/checkout@v4
- name: Setup cmake
uses: jwlawson/actions-setup-cmake@v2
with:
cmake-version: '3.30.x'
- name: install msys2 and arrow on windows
Copy link
Collaborator

@hntd187 hntd187 Jul 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not windows or I should say this is not typically how someone using msvc would do. I think a build using msvc would be useful too.

if: matrix.os == 'windows-latest'
uses: msys2/setup-msys2@v2
with:
update: true
install: mingw-w64-ucrt-x86_64-arrow
- name: Install arrow-glib
shell: bash
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
sudo apt update
Expand All @@ -88,6 +96,8 @@ jobs:
elif [ "$RUNNER_OS" == "macOS" ]; then
brew install apache-arrow
brew install apache-arrow-glib
elif [ "$RUNNER_OS" == "Windows" ]; then
echo "Handled by previous step"
else
echo "$RUNNER_OS not supported"
exit 1
Expand Down
Loading