Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLPX-88349 Upgrade sshj 0.37.0 with Raul's mod dlpx73623 #8

Conversation

lschetanrao
Copy link

@lschetanrao lschetanrao commented Oct 16, 2023

JIRA : https://delphix.atlassian.net/browse/DLPX-88349

Description

Updating sshj with custom changes.

Solution

This PR contains following changes

  1. Clean cherry-pick of commits from DLPX-88137 Upgrade sshj with Raul's mod dlpx73623 #7 on top of the latest release, 0.37.0.

Published the JAR on artifactory as version 0.37.0-dlpx73623. - LINK
Published the POM file by copying the pom from here and replacing version from 0.37.0 to 0.37.0-dlpx732623

@lschetanrao lschetanrao force-pushed the dlpx/pr/lschetanrao/50203d81-e0d7-4812-9b40-0fde5f1939b6 branch from dc40ef5 to 6ca0049 Compare October 16, 2023 06:47
@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (3b67d2b) 68.48% compared to head (6ca0049) 68.58%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             DLPX-88349-on-0.37.0       #8      +/-   ##
==========================================================
+ Coverage                   68.48%   68.58%   +0.10%     
- Complexity                   1401     1416      +15     
==========================================================
  Files                         207      208       +1     
  Lines                        7475     7544      +69     
  Branches                      630      639       +9     
==========================================================
+ Hits                         5119     5174      +55     
- Misses                       2022     2033      +11     
- Partials                      334      337       +3     
Files Coverage Δ
...hmizz/sshj/connection/channel/AbstractChannel.java 74.69% <ø> (ø)
...sshj/connection/channel/direct/SessionChannel.java 50.00% <ø> (ø)
src/main/java/net/schmizz/sshj/ConfigImpl.java 84.61% <50.00%> (-2.27%) ⬇️
...n/java/net/schmizz/sshj/common/CircularBuffer.java 88.40% <88.40%> (ø)
...zz/sshj/connection/channel/ChannelInputStream.java 75.80% <42.85%> (-1.47%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lschetanrao lschetanrao self-assigned this Oct 16, 2023
@lschetanrao lschetanrao marked this pull request as ready for review October 16, 2023 07:30
Copy link

@VenkatanadhanG VenkatanadhanG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wait for Raul's approval and merge.

@lschetanrao lschetanrao merged commit 520b78e into DLPX-88349-on-0.37.0 Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants