Skip to content

Commit

Permalink
regulator: bd70528: Remove .set_ramp_delay for bd70528_ldo_ops
Browse files Browse the repository at this point in the history
The .set_ramp_delay should be for bd70528_buck_ops only.
Setting .set_ramp_delay for for bd70528_ldo_ops causes problem because
BD70528_MASK_BUCK_RAMP (0x10) overlaps with BD70528_MASK_LDO_VOLT (0x1f).
So setting ramp_delay for LDOs may change the voltage output, fix it.

Fixes: 99ea37b ("regulator: bd70528: Support ROHM BD70528 regulator block")
Signed-off-by: Axel Lin <[email protected]>
Acked-by: Matti Vaittinen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
AxelLin authored and broonie committed Jan 3, 2020
1 parent 71dd2fe commit 6f1ff76
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/regulator/bd70528-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ static const struct regulator_ops bd70528_ldo_ops = {
.set_voltage_sel = regulator_set_voltage_sel_regmap,
.get_voltage_sel = regulator_get_voltage_sel_regmap,
.set_voltage_time_sel = regulator_set_voltage_time_sel,
.set_ramp_delay = bd70528_set_ramp_delay,
};

static const struct regulator_ops bd70528_led_ops = {
Expand Down

0 comments on commit 6f1ff76

Please sign in to comment.