Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 316: handle missing TOP and broken HCONS #318

Closed
wants to merge 3 commits into from

Conversation

arademaker
Copy link
Member

@goodmami , can you please check and validate if my solution is ok? I am following the Lisp code from @oepen reported by him in the message

http://lists.delph-in.net/archives/developers/2020/003140.html

Copy link
Member

@goodmami goodmami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments below, but also I'd want to see some unit tests added that fail except for the fixes introduced by this change. There are several in #316.

delphin/eds/_operations.py Show resolved Hide resolved
delphin/eds/_operations.py Show resolved Hide resolved
delphin/eds/_operations.py Show resolved Hide resolved
@goodmami goodmami changed the title fix issue 316 Fix issue 316: handle missing TOP and broken HCONS Sep 30, 2020
@goodmami
Copy link
Member

Hmm, I merged and pushed these commits, so the PR should have closed. Anyway, the commits are in the develop branch now. I addressed the changes that I'd requested in this PR.

@goodmami goodmami closed this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants