DMRS.scopal_arguments: return correct scope labels

Fixes #249
delph-in · Aug 15, 2019 · 0588020 · 0588020
1 parent 023ec82
commit 0588020
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/delphin/dmrs/_dmrs.py b/delphin/dmrs/_dmrs.py
@@ -347,7 +347,7 @@ def scopal_arguments(self, scopes=None):
                 continue
             # get the label if scopes was given
             target = id_to_lbl.get(link.end, link.end)
-            scargs[link.start].append((link.role, relation, label))
+            scargs[link.start].append((link.role, relation, target))
 
         return scargs
 

diff --git a/tests/dmrs_test.py b/tests/dmrs_test.py
@@ -108,3 +108,25 @@ def test_arguments(self, dogs_bark):
             10001: [],
             10002: []
         }
+
+    def test_scopal_arguments(self, dogs_bark):
+        d = dmrs.DMRS()
+        assert d.scopal_arguments() == {}
+
+        d = dmrs.DMRS(**dogs_bark)
+        assert d.scopal_arguments() == {
+            10000: [],
+            10001: [('RSTR', 'qeq', 10002)],
+            10002: []
+        }
+
+        _, scopes = d.scopes()
+        scopemap = {}
+        for lbl, nodes in scopes.items():
+            for node in nodes:
+                scopemap[node.id] = lbl
+        assert d.scopal_arguments(scopes=scopes) == {
+            10000: [],
+            10001: [('RSTR', 'qeq', scopemap[10002])],
+            10002: []
+        }