Fixing virtual media and idrac attributes resource #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prajwalpatil25
commented
Nov 21, 2023
prajwalpatil25
commented
- Fixed bug with virtual media where server credentials were getting read from state instead of plan in update.
- Fixed bug with iDRAC attributes resource where it didn't returned after error.
prajwalpatil25
requested review from
Sakshi-dell,
Krishnan-Priyanshu and
rounak-adhikary
Sakshi-dell
approved these changes
Nov 21, 2023
Sakshi-dell
added a commit
that referenced
this pull request
Nov 24, 2023
* Adding inittial lintersin makefile and gha * Fixing wrong vendor * Adding security checks and exclusions * Chnaging to golangci-lint * Fix yaml * Fix 2 * Fix 3 * provider migration + code reorg * Adding uppercaseconst comment * Removing vendor * Adding linting and fixing some stuff * Adding vendor and golangci * rename ssl_insecure to validate_cert * moved resouce /datasource templates to template-bcks folder/ * fix the attribute name and removed redundant github action jobs * provider model fixed * fix gen * Adding simple update resource initial * power resource migration * added power template * Added debug messages * migrate idrac_attribute resource * migration of idrac attribute CRUD * fmt fix * migrated idrac attribute datasource * fix generate * user resource migrated * me more changes * Migrated virtual media resource * removed comments * Fixing lint issues * Updating docs * Fixing linting issues * fix lint issue * Update resource_redfish_dell_idrac_attributes.go * initial bios ds * Working bios ds * Generating docs * Some cleanup * lint fix * Fixing linter issues * Relaxing checks * Gnenerate * Linter fix 1 * Re-enabled linting for bios-ds * linting issue fixed * ran go generate * Removing skip entries for user and virtual media resources * Removing commented entry * Updating comments * minor issue fixed * minor issue fixed * ran make generate * acceptance tests fix * fixed linting issues * split create method * addressed review comment * Added doc template * changes in md * changes in md * added constants to constants.go * migrated virtual media datasource * minor fix in redfish server config - power resource * make generate fix * fixed liniting issues * moved 'virtual_media' definition to attributes * refactor redfish server schema * removed '=' from redfish server config * remove validate check * Storage Datasource TPF Migration (#115) * Storage Datasource migration * Docs * Fixing tests after merge * Lint fix * added back ssl_insecure & removed version from schema for backward compatibility (#117) * Firmware inventory datasource (#118) * Firmware Inventory datasource * Firmware Inventory datasource * formatting issue fixed * doc issuue fixed * comments addressed * bios resource Migrated (#120) * bios resource Migrated * comments addressed * System boot datasource migration to TPF (#121) * System boot datasource migration to TPF * linting fix * fixed doc * removed commented code * Storage Volume resource migration to TPF (#119) * volume migration to tpf * Storage volume migration to TPF * Updated volume model * Fixed linting * fixed md * fixed applytime onreset for create * linting fix * code restructuring * addressed review comments --------- Co-authored-by: Krishnan-Priyanshu <[email protected]> * User resource minor fix (#124) * fixing virtual media and idrac attributes (#125) * Miscellaneous changes for migration (#126) * Merging templates and templates-bck * System Boot datasource backward compatibility fix * Regenerating docs * Adding Lock mutex for simple update * Removing unused comments --------- Co-authored-by: Krishnan-Priyanshu <[email protected]> Co-authored-by: Priyanshu Krishnan <[email protected]> Co-authored-by: Sakshi_makkar <[email protected]> Co-authored-by: prajwalpatil25 <[email protected]> Co-authored-by: Sakshi-dell <[email protected]> Co-authored-by: prajwalpatil25 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.